power_supply: 88pm860x: Fix leaked power supply on probe fail
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Tue, 27 Jan 2015 15:51:54 +0000 (16:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 22:40:49 +0000 (14:40 -0800)
commit 24727b45b484e8937dcde53fa8d1aa70ac30ec0c upstream.

Driver forgot to unregister power supply if request_threaded_irq()
failed in probe(). In such case the memory associated with power supply
leaked.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: a830d28b48bf ("power_supply: Enable battery-charger for 88pm860x")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/88pm860x_charger.c

index 36fb4b5a4b0d6e314e84e9e8803c3193f9cb5931..1ef35ab79d0f6dbdfebddf18e280f3a1b5899bdf 100644 (file)
@@ -711,6 +711,7 @@ static int pm860x_charger_probe(struct platform_device *pdev)
        return 0;
 
 out_irq:
+       power_supply_unregister(&info->usb);
        while (--i >= 0)
                free_irq(info->irq[i], info);
 out: