llvm-cov: Explicitly namespace llvm::make_unique to keep MSVC happy
authorJustin Bogner <mail@justinbogner.com>
Wed, 7 May 2014 16:01:27 +0000 (16:01 +0000)
committerJustin Bogner <mail@justinbogner.com>
Wed, 7 May 2014 16:01:27 +0000 (16:01 +0000)
This is a followup to r208171, where a call to make_unique was
disambiguated for MSVC. Disambiguate two more calls, and remove the
comment about it since this is what we do everywhere.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208219 91177308-0d34-0410-b5e6-96231b3b80d8

lib/IR/GCOV.cpp

index e8d26e0d9e155a1adda5b22a31976f970d5213b9..f2099d6baf132d6aef5608ddd8c879b815b7cf42 100644 (file)
@@ -511,16 +511,14 @@ std::string FileInfo::getCoveragePath(StringRef Filename,
 std::unique_ptr<raw_ostream>
 FileInfo::openCoveragePath(StringRef CoveragePath) {
   if (Options.NoOutput)
-    return make_unique<raw_null_ostream>();
+    return llvm::make_unique<raw_null_ostream>();
 
   std::string ErrorInfo;
-  // FIXME: When using MSVS, we end up having both std::make_unique and
-  // llvm::make_unique which conflict.  Explicitly use the llvm:: version.
   auto OS = llvm::make_unique<raw_fd_ostream>(CoveragePath.str().c_str(),
                                               ErrorInfo, sys::fs::F_Text);
   if (!ErrorInfo.empty()) {
     errs() << ErrorInfo << "\n";
-    return make_unique<raw_null_ostream>();
+    return llvm::make_unique<raw_null_ostream>();
   }
   return std::move(OS);
 }