perf ui tui: Register the error callbacks before initializing the widgets
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 22 Oct 2015 19:44:17 +0000 (16:44 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 22 Oct 2015 19:44:17 +0000 (16:44 -0300)
I.e. we want to tell the user about errors found during, for instance,
the ui_browser initialization, so that a call to ui__warning() appears
as a window waiting for a key to be pressed.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-ederrwizcl6mfz10vfobl5qq@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/tui/setup.c

index 60d1f29b4b50a9fedf0a163855056edfce1ed22b..7dfeba0a91f37c33c87b826e9ed79ec4ad59869c 100644 (file)
@@ -141,10 +141,6 @@ int ui__init(void)
 
        SLkp_define_keysym((char *)"^(kB)", SL_KEY_UNTAB);
 
-       ui_helpline__init();
-       ui_browser__init();
-       tui_progress__init();
-
        signal(SIGSEGV, ui__signal_backtrace);
        signal(SIGFPE, ui__signal_backtrace);
        signal(SIGINT, ui__signal);
@@ -153,6 +149,10 @@ int ui__init(void)
 
        perf_error__register(&perf_tui_eops);
 
+       ui_helpline__init();
+       ui_browser__init();
+       tui_progress__init();
+
        hist_browser__init_hpp();
 out:
        return err;