target: Inline transport_get_sense_codes()
authorBart Van Assche <bart.vanassche@sandisk.com>
Wed, 8 Jul 2015 14:58:50 +0000 (17:58 +0300)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 24 Jul 2015 05:08:33 +0000 (22:08 -0700)
Inline this function in its call site since it performs a trivial
task and since it is only called once.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c

index ce8574b7220ced193e969e46141c411156e7e9a7..b6708d1b69b80821eb5ad55ed2b447eb4cc637c1 100644 (file)
@@ -2615,17 +2615,6 @@ bool transport_wait_for_tasks(struct se_cmd *cmd)
 }
 EXPORT_SYMBOL(transport_wait_for_tasks);
 
-static int transport_get_sense_codes(
-       struct se_cmd *cmd,
-       u8 *asc,
-       u8 *ascq)
-{
-       *asc = cmd->scsi_asc;
-       *ascq = cmd->scsi_ascq;
-
-       return 0;
-}
-
 static
 void transport_err_sector_info(unsigned char *buffer, sector_t bad_sector)
 {
@@ -2819,9 +2808,8 @@ transport_send_check_condition_and_sense(struct se_cmd *cmd,
                buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10;
                /* Not Ready */
                buffer[SPC_SENSE_KEY_OFFSET] = NOT_READY;
-               transport_get_sense_codes(cmd, &asc, &ascq);
-               buffer[SPC_ASC_KEY_OFFSET] = asc;
-               buffer[SPC_ASCQ_KEY_OFFSET] = ascq;
+               buffer[SPC_ASC_KEY_OFFSET] = cmd->scsi_asc;
+               buffer[SPC_ASCQ_KEY_OFFSET] = cmd->scsi_ascq;
                break;
        case TCM_MISCOMPARE_VERIFY:
                /* CURRENT ERROR */