PCI: pciehp: Make check_link_active() non-static
authorRajat Jain <rajatxjain@gmail.com>
Wed, 5 Feb 2014 02:28:43 +0000 (18:28 -0800)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 11 Feb 2014 01:12:19 +0000 (18:12 -0700)
check_link_active() functionality needs to be used by subsequent patches
(that introduce link state change based hotplug). Thus make the function
non-static, and rename it to pciehp_check_link_active() so as to be
consistent with other non-static functions.

Signed-off-by: Rajat Jain <rajatxjain@gmail.com>
Signed-off-by: Rajat Jain <rajatjain@juniper.net>
Signed-off-by: Guenter Roeck <groeck@juniper.net>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pciehp.h
drivers/pci/hotplug/pciehp_hpc.c

index 88b37cad4b35eed91fa48b8fbcecc569744f7a45..f9524592da0f09ad549aa8ae1c3cc3cad6df166b 100644 (file)
@@ -153,6 +153,7 @@ void pciehp_green_led_on(struct slot *slot);
 void pciehp_green_led_off(struct slot *slot);
 void pciehp_green_led_blink(struct slot *slot);
 int pciehp_check_link_status(struct controller *ctrl);
+bool pciehp_check_link_active(struct controller *ctrl);
 void pciehp_release_ctrl(struct controller *ctrl);
 int pciehp_reset_slot(struct slot *slot, int probe);
 
index 14acfccb767072bb58b00417413afb55747ac0e5..aed6ab43cc13227091b710ff00882db53c6ec5ca 100644 (file)
@@ -206,7 +206,7 @@ static void pcie_write_cmd(struct controller *ctrl, u16 cmd, u16 mask)
        mutex_unlock(&ctrl->ctrl_lock);
 }
 
-static bool check_link_active(struct controller *ctrl)
+bool pciehp_check_link_active(struct controller *ctrl)
 {
        struct pci_dev *pdev = ctrl_dev(ctrl);
        u16 lnk_status;
@@ -225,12 +225,12 @@ static void __pcie_wait_link_active(struct controller *ctrl, bool active)
 {
        int timeout = 1000;
 
-       if (check_link_active(ctrl) == active)
+       if (pciehp_check_link_active(ctrl) == active)
                return;
        while (timeout > 0) {
                msleep(10);
                timeout -= 10;
-               if (check_link_active(ctrl) == active)
+               if (pciehp_check_link_active(ctrl) == active)
                        return;
        }
        ctrl_dbg(ctrl, "Data Link Layer Link Active not %s in 1000 msec\n",