ASoC: rsnd: tidyup parameter assignment position
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 21 Jul 2015 00:03:35 +0000 (00:03 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 21 Jul 2015 10:39:42 +0000 (11:39 +0100)
84e95355602c("ASoC: rsnd: show debug message for SSI/SRC/DVC connection")
added debug message on rsnd_dai_connect(), but the relationship of
parameter check was absurdity. This patch tidyup it.
It is reported via Smatch/Dan

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c

index 927a7b02123b35d16ad0365c47ac83777288dbc0..f3feed5ce9b65ba67d936a399a4a06f91cf77db7 100644 (file)
@@ -332,12 +332,15 @@ u32 rsnd_get_dalign(struct rsnd_mod *mod, struct rsnd_dai_stream *io)
 static int rsnd_dai_connect(struct rsnd_mod *mod,
                            struct rsnd_dai_stream *io)
 {
-       struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
-       struct device *dev = rsnd_priv_to_dev(priv);
+       struct rsnd_priv *priv;
+       struct device *dev;
 
        if (!mod)
                return -EIO;
 
+       priv = rsnd_mod_to_priv(mod);
+       dev = rsnd_priv_to_dev(priv);
+
        io->mod[mod->type] = mod;
 
        dev_dbg(dev, "%s[%d] is connected to io (%s)\n",