usb: gadget: f_fs: add missing spinlock and mutex unlock
authorRobert Baldyga <r.baldyga@samsung.com>
Mon, 10 Mar 2014 08:33:37 +0000 (09:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Mar 2014 23:05:31 +0000 (16:05 -0700)
This patch adds missing spin_unlock and mutex_unlock calls in
error handling code.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_fs.c

index 10c086afa2f44029e2121017f2a725a9722029bb..2e164dca08e89fc29ea1887f0afe7b2a09e1a5af 100644 (file)
@@ -802,7 +802,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
                if (io_data->aio) {
                        req = usb_ep_alloc_request(ep->ep, GFP_KERNEL);
                        if (unlikely(!req))
-                               goto error;
+                               goto error_lock;
 
                        req->buf      = data;
                        req->length   = io_data->len;
@@ -817,7 +817,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
                        ret = usb_ep_queue(ep->ep, req, GFP_ATOMIC);
                        if (unlikely(ret)) {
                                usb_ep_free_request(ep->ep, req);
-                               goto error;
+                               goto error_lock;
                        }
                        ret = -EIOCBQUEUED;
 
@@ -865,6 +865,10 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
 
        mutex_unlock(&epfile->mutex);
        return ret;
+
+error_lock:
+       spin_unlock_irq(&epfile->ffs->eps_lock);
+       mutex_unlock(&epfile->mutex);
 error:
        kfree(data);
        return ret;