[XFS] Don't allow memory reclaim to wait on the filesystem in inode
authorDavid Chinner <dgc@sgi.com>
Mon, 19 May 2008 06:29:34 +0000 (16:29 +1000)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Fri, 23 May 2008 05:26:03 +0000 (15:26 +1000)
writeback

If we allow memory reclaim to wait on the pages under writeback in inode
cluster writeback we could deadlock because we are currently holding the
ILOCK on the initial writeback inode which is needed in data I/O
completion to change the file size or do unwritten extent conversion
before the pages are taken out of writeback state.

SGI-PV: 981091
SGI-Modid: xfs-linux-melb:xfs-kern:31015a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/xfs_inode.c

index cf0bb9c1d621fb702897acdfd41bed22cabf8e67..739ea45a9d10f0246c0ad13f1167a5707ff54a89 100644 (file)
@@ -2986,7 +2986,7 @@ xfs_iflush_cluster(
        ASSERT(pag->pag_ici_init);
 
        ilist_size = XFS_INODE_CLUSTER_SIZE(mp) * sizeof(xfs_inode_t *);
-       ilist = kmem_alloc(ilist_size, KM_MAYFAIL);
+       ilist = kmem_alloc(ilist_size, KM_MAYFAIL|KM_NOFS);
        if (!ilist)
                return 0;