drm/i915: clarify IBX dp workaround
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 30 May 2012 10:31:56 +0000 (12:31 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 1 Jun 2012 19:38:59 +0000 (21:38 +0200)
Instead of checking for !CPT, check for IBX to make it clearer that
this is a IBX-specific workaround. No functional change because we
smash the PPT PCH into the HAS_PCH_CPT check and atm DP isn't enabled
on the haswell LPT PCH yet.

See Bspec Vol 3, Part 3, Section 4.[3-5].1 about DP[BCD], bit 30 for
details of this workaround.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index c71e7890e6f6127fdd10554ea30618b0105ab3cb..ade98e0bca845f0830a3ccc496328df37397da6b 100644 (file)
@@ -1914,7 +1914,7 @@ intel_dp_link_down(struct intel_dp *intel_dp)
                        DP |= DP_LINK_TRAIN_OFF;
        }
 
-       if (!HAS_PCH_CPT(dev) &&
+       if (HAS_PCH_IBX(dev) &&
            I915_READ(intel_dp->output_reg) & DP_PIPEB_SELECT) {
                struct drm_crtc *crtc = intel_dp->base.base.crtc;