[llvm-pdbdump] Very minor code cleanup.

This just removes some dead enums as well as some debug flushes
of stdout.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230204 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h b/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h
index 002a46e60ffb36a795320549afba5592ec745fc5..c71f35c7b60fcdfd4833fa663364c58e206a0fe3 100644 (file)
--- a/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h
+++ b/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h
@@ -19,7 +19,7 @@ class DIARawSymbol : public IPDBRawSymbol {
 public:
   DIARawSymbol(const DIASession &PDBSession, CComPtr<IDiaSymbol> DiaSymbol);
 
-  void dump(raw_ostream &OS, int Indent, PDB_DumpLevel Level) const override;
+  void dump(raw_ostream &OS, int Indent) const override;
 
   CComPtr<IDiaSymbol> getDiaSymbol() const { return Symbol; }
 

diff --git a/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h b/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
index b557fd1b69688b88fc8f64a09ddb93384d9f0f60..139bff56fd5deed43a27eba90660eff63b37261b 100644 (file)
--- a/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
+++ b/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
@@ -28,7 +28,7 @@ class IPDBRawSymbol {
 public:
   virtual ~IPDBRawSymbol();
 
-  virtual void dump(raw_ostream &OS, int Indent, PDB_DumpLevel Level) const = 0;
+  virtual void dump(raw_ostream &OS, int Indent) const = 0;
 
   virtual std::unique_ptr<IPDBEnumSymbols>
   findChildren(PDB_SymType Type) const = 0;

diff --git a/include/llvm/DebugInfo/PDB/IPDBSourceFile.h b/include/llvm/DebugInfo/PDB/IPDBSourceFile.h
index e55966c50c19c97996d9bdc5bee5780ce9d28420..55000eff02f02fd38adb2a51baa3925a42629574 100644 (file)
--- a/include/llvm/DebugInfo/PDB/IPDBSourceFile.h
+++ b/include/llvm/DebugInfo/PDB/IPDBSourceFile.h
@@ -24,7 +24,7 @@ class IPDBSourceFile {
 public:
   virtual ~IPDBSourceFile();
 
-  void dump(raw_ostream &OS, int Indent, PDB_DumpLevel Level) const;
+  void dump(raw_ostream &OS, int Indent) const;
 
   virtual std::string getFileName() const = 0;
   virtual uint32_t getUniqueId() const = 0;

diff --git a/include/llvm/DebugInfo/PDB/PDBSymbol.h b/include/llvm/DebugInfo/PDB/PDBSymbol.h
index 29062d68f482028709728657b3a6214468504630..36005eb666051889909851182ef44c7e1e960e73 100644 (file)
--- a/include/llvm/DebugInfo/PDB/PDBSymbol.h
+++ b/include/llvm/DebugInfo/PDB/PDBSymbol.h
@@ -55,7 +55,7 @@ public:
   /// override the behavior to only dump known fields.
   virtual void dump(raw_ostream &OS, int Indent,
                     PDBSymDumper &Dumper) const = 0;
-  void defaultDump(raw_ostream &OS, int Indent, PDB_DumpLevel Level) const;
+  void defaultDump(raw_ostream &OS, int Indent) const;
 
   PDB_SymType getSymTag() const;
 

diff --git a/include/llvm/DebugInfo/PDB/PDBTypes.h b/include/llvm/DebugInfo/PDB/PDBTypes.h
index c797ccaf34fa903aeaaca2c38c27264e4fa173bb..75b64750129dc5a14c705590cae2e7ce634689dc 100644 (file)
--- a/include/llvm/DebugInfo/PDB/PDBTypes.h
+++ b/include/llvm/DebugInfo/PDB/PDBTypes.h
@@ -67,50 +67,6 @@ enum class PDB_ReaderType {
   DIA = 0,
 };
 
-enum class PDB_DumpLevel {
-  Compact,
-  Normal,
-  Detailed,
-};
-
-enum PDB_DumpFlags {
-  PDB_DF_None = 0x0,
-  PDB_DF_Functions = 0x1,  // Dump functions
-  PDB_DF_Data = 0x2,       // Dump variables and constants
-  PDB_DF_Labels = 0x4,     // Dump labels
-  PDB_DF_PublicSyms = 0x8, // Dump public symbols
-  PDB_DF_Classes = 0x10,   // Dump class types
-  PDB_DF_Enums = 0x20,     // Dump enums
-  PDB_DF_Funcsigs = 0x40,  // Dump function signatures
-  PDB_DF_VTables = 0x80,   // Dump virtual function tables
-  PDB_DF_Thunks = 0x100,   // Dump thunks
-  PDB_DF_ObjFiles = 0x200, // Dump object files (compilands)
-  PDB_DF_Typedefs = 0x400, // Dump typedefs
-  PDB_DF_Children = 0x800, // Dump children of the current symbol
-  PDB_DF_Hidden = 0x1000,  // Dump everything.  This is not simply a bitwise
-                           // or of the previous flags.  It will find symbols
-                           // that would otherwise be missed, but can lead to
-                           // much slower dumps for large input files.
-  PDB_DF_All = 0x7FF
-};
-inline PDB_DumpFlags operator|(PDB_DumpFlags LHS, PDB_DumpFlags RHS) {
-  return static_cast<PDB_DumpFlags>((int)LHS | (int)RHS);
-}
-
-inline PDB_DumpFlags operator&(PDB_DumpFlags LHS, PDB_DumpFlags RHS) {
-  return static_cast<PDB_DumpFlags>((int)LHS & (int)RHS);
-}
-
-inline PDB_DumpFlags operator~(PDB_DumpFlags LHS) {
-  return static_cast<PDB_DumpFlags>(~(int)LHS);
-}
-inline PDB_DumpFlags &operator|=(PDB_DumpFlags &LHS, PDB_DumpFlags RHS) {
-  return (LHS = (LHS | RHS));
-}
-inline PDB_DumpFlags &operator&=(PDB_DumpFlags &LHS, PDB_DumpFlags RHS) {
-  return (LHS = (LHS & RHS));
-}
-
 /// Defines a 128-bit unique identifier.  This maps to a GUID on Windows, but
 /// is abstracted here for the purposes of non-Windows platforms that don't have
 /// the GUID structure defined.

diff --git a/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp b/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp
index 0ce3df528e1833c8a18f9477987472087d28af17..abe0ab55e56c63355aa87578f1b98914dd4f6c0b 100644 (file)
--- a/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp
+++ b/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp
@@ -179,8 +179,7 @@ DIARawSymbol::DIARawSymbol(const DIASession &PDBSession,
 #define RAW_METHOD_DUMP(Stream, Method)                                        \
   DumpDIAValue(Stream, Indent, StringRef(#Method), Symbol, &IDiaSymbol::Method);
 
-void DIARawSymbol::dump(raw_ostream &OS, int Indent,
-                        PDB_DumpLevel Level) const {
+void DIARawSymbol::dump(raw_ostream &OS, int Indent) const {
   RAW_METHOD_DUMP(OS, get_access)
   RAW_METHOD_DUMP(OS, get_addressOffset)
   RAW_METHOD_DUMP(OS, get_addressSection)

diff --git a/lib/DebugInfo/PDB/IPDBSourceFile.cpp b/lib/DebugInfo/PDB/IPDBSourceFile.cpp
index f98bf9b18fc77ec51a2d1705af52c515c0bc5f89..3abe59dba623df0a16e39776d5ae8e6216270c7d 100644 (file)
--- a/lib/DebugInfo/PDB/IPDBSourceFile.cpp
+++ b/lib/DebugInfo/PDB/IPDBSourceFile.cpp
@@ -17,19 +17,16 @@ using namespace llvm;
 
 IPDBSourceFile::~IPDBSourceFile() {}
 
-void IPDBSourceFile::dump(raw_ostream &OS, int Indent,
-                          PDB_DumpLevel Level) const {
-  if (Level == PDB_DumpLevel::Compact) {
-    OS.indent(Indent);
-    PDB_Checksum ChecksumType = getChecksumType();
-    OS << "[";
-    if (ChecksumType != PDB_Checksum::None) {
-      OS << ChecksumType << ": ";
-      std::string Checksum = getChecksum();
-      for (uint8_t c : Checksum)
-        OS << format_hex_no_prefix(c, 2, true);
-    } else
-      OS << "No checksum";
-    OS << "] " << getFileName() << "\n";
-  }
+void IPDBSourceFile::dump(raw_ostream &OS, int Indent) const {
+  OS.indent(Indent);
+  PDB_Checksum ChecksumType = getChecksumType();
+  OS << "[";
+  if (ChecksumType != PDB_Checksum::None) {
+    OS << ChecksumType << ": ";
+    std::string Checksum = getChecksum();
+    for (uint8_t c : Checksum)
+      OS << format_hex_no_prefix(c, 2, true);
+  } else
+    OS << "No checksum";
+  OS << "] " << getFileName() << "\n";
 }

diff --git a/lib/DebugInfo/PDB/PDBSymbol.cpp b/lib/DebugInfo/PDB/PDBSymbol.cpp
index f24e318a941c99c22417c58eb41cebd26ad1380e..f9aaf3ae934df4532629910bf466a3a4ec54d5e1 100644 (file)
--- a/lib/DebugInfo/PDB/PDBSymbol.cpp
+++ b/lib/DebugInfo/PDB/PDBSymbol.cpp
@@ -107,9 +107,8 @@ PDBSymbol::create(const IPDBSession &PDBSession,
 
 #define ELSE_TRY_DUMP_TYPE(Type, Dumper) else TRY_DUMP_TYPE(Type, Dumper)
 
-void PDBSymbol::defaultDump(raw_ostream &OS, int Indent,
-                            PDB_DumpLevel Level) const {
-  RawSymbol->dump(OS, Indent, Level);
+void PDBSymbol::defaultDump(raw_ostream &OS, int Indent) const {
+  RawSymbol->dump(OS, Indent);
 }
 
 PDB_SymType PDBSymbol::getSymTag() const { return RawSymbol->getSymTag(); }

diff --git a/tools/llvm-pdbdump/ClassDefinitionDumper.cpp b/tools/llvm-pdbdump/ClassDefinitionDumper.cpp
index f6bb6958d8bdcc43455d363d7965768dd37fd342..7e9407df3d9337cb2e4fcc7fca5214186b40422f 100644 (file)
--- a/tools/llvm-pdbdump/ClassDefinitionDumper.cpp
+++ b/tools/llvm-pdbdump/ClassDefinitionDumper.cpp
@@ -85,7 +85,6 @@ void ClassDefinitionDumper::start(const PDBSymbolTypeUDT &Class,
   if (Count > 0)
     OS << newline(Indent);
   OS << "}";
-  OS.flush();
 }
 
 int ClassDefinitionDumper::dumpAccessGroup(PDB_MemberAccess Access,
@@ -147,7 +146,6 @@ void ClassDefinitionDumper::dump(const PDBSymbolTypeTypedef &Symbol,
   OS << newline(Indent);
   TypedefDumper Dumper;
   Dumper.start(Symbol, OS, Indent);
-  OS.flush();
 }
 
 void ClassDefinitionDumper::dump(const PDBSymbolTypeUDT &Symbol,

diff --git a/tools/llvm-pdbdump/FunctionDumper.cpp b/tools/llvm-pdbdump/FunctionDumper.cpp
index 1bd201b8f69dd047865cb16d6fd9e952b6ea55b6..e65983034a6a89d7f21011af45b75d408161b3ad 100644 (file)
--- a/tools/llvm-pdbdump/FunctionDumper.cpp
+++ b/tools/llvm-pdbdump/FunctionDumper.cpp
@@ -163,7 +163,6 @@ void FunctionDumper::start(const PDBSymbolFunc &Symbol, PointerType Pointer,
         OS << ", ";
     }
   }
-  OS.flush();
   OS << ")";
   if (Symbol.isConstType())
     OS << " const";
@@ -202,8 +201,7 @@ void FunctionDumper::dump(const PDBSymbolTypeFunctionArg &Symbol,
                           raw_ostream &OS, int Indent) {
   // PDBSymbolTypeFunctionArg is just a shim over the real argument.  Just drill
   // through to the real thing and dump it.
-  Symbol.defaultDump(OS, Indent, PDB_DumpLevel::Detailed);
-  OS.flush();
+  Symbol.defaultDump(OS, Indent);
   uint32_t TypeId = Symbol.getTypeId();
   auto Type = Symbol.getSession().getSymbolById(TypeId);
   if (!Type)

diff --git a/tools/llvm-pdbdump/TypeDumper.cpp b/tools/llvm-pdbdump/TypeDumper.cpp
index c4e2eabda905bccd4798a8f9f6d244364bdeed61..3131e9f00ccc54df19f44fb206e96c8a710cbdce 100644 (file)
--- a/tools/llvm-pdbdump/TypeDumper.cpp
+++ b/tools/llvm-pdbdump/TypeDumper.cpp
@@ -78,7 +78,6 @@ void TypeDumper::dump(const PDBSymbolTypeTypedef &Symbol, raw_ostream &OS,
 
   TypedefDumper Dumper;
   Dumper.start(Symbol, OS, Indent);
-  OS.flush();
 }
 
 void TypeDumper::dump(const PDBSymbolTypeUDT &Symbol, raw_ostream &OS,

diff --git a/tools/llvm-pdbdump/TypedefDumper.cpp b/tools/llvm-pdbdump/TypedefDumper.cpp
index e3ac76a63b36ac3ac8792416ccf27b6975757f60..6eea6b69d95ae8a59ade681d498530d849f6d9ff 100644 (file)
--- a/tools/llvm-pdbdump/TypedefDumper.cpp
+++ b/tools/llvm-pdbdump/TypedefDumper.cpp
@@ -66,7 +66,6 @@ void TypedefDumper::dump(const PDBSymbolTypePointer &Symbol, raw_ostream &OS,
       Pointer = FunctionDumper::PointerType::Reference;
     FunctionDumper NestedDumper;
     NestedDumper.start(*FuncSig, Pointer, OS);
-    OS.flush();
   } else {
     PointeeType->dump(OS, Indent, *this);
     OS << ((Symbol.isReference()) ? "&" : "*");

diff --git a/tools/llvm-pdbdump/VariableDumper.cpp b/tools/llvm-pdbdump/VariableDumper.cpp
index cb9c66a94b93aae51bf136f4b59bed0565590a94..31348ef1e1799c64df95c5f23f97ca41f2731407 100644 (file)
--- a/tools/llvm-pdbdump/VariableDumper.cpp
+++ b/tools/llvm-pdbdump/VariableDumper.cpp
@@ -48,7 +48,6 @@ void VariableDumper::start(const PDBSymbolData &Var, raw_ostream &OS,
   case PDB_LocType::ThisRel: {
     int Offset = Var.getOffset();
     OS << "+" << format_hex(Var.getOffset(), 4) << " ";
-    OS.flush();
     dumpSymbolTypeAndName(*VarType, Var.getName(), OS);
     break;
   }

diff --git a/unittests/DebugInfo/PDB/PDBApiTest.cpp b/unittests/DebugInfo/PDB/PDBApiTest.cpp
index 7cee8b9ad9010ddc3e912577b51a8be303934770..629c5f8bc0ec70ae8856701d2c756f49c6da1119 100644 (file)
--- a/unittests/DebugInfo/PDB/PDBApiTest.cpp
+++ b/unittests/DebugInfo/PDB/PDBApiTest.cpp
@@ -90,7 +90,7 @@ public:
   MockRawSymbol(PDB_SymType SymType)
       : Type(SymType) {}
 
-  void dump(raw_ostream &OS, int Indent, PDB_DumpLevel Level) const override {}
+  void dump(raw_ostream &OS, int Indent) const override {}
 
   std::unique_ptr<IPDBEnumSymbols>
   findChildren(PDB_SymType Type) const override {