Rephrase Optional usage to quite warnings

Reviewed By: yfeldblum

Differential Revision: D5105818

fbshipit-source-id: e3926a0c70a68855e0180bdd44cb0ec76e66bb94

diff --git a/folly/gen/Base-inl.h b/folly/gen/Base-inl.h
index 2245bf08bfa8c28e5341e5ec87b8337f3fc948fb..66d2b92c3dec49617e2e73daded85006f1d4dd92 100644 (file)
--- a/folly/gen/Base-inl.h
+++ b/folly/gen/Base-inl.h
@@ -1866,8 +1866,8 @@ class Reduce : public Operator<Reduce<Reducer>> {
     static_assert(!Source::infinite, "Cannot reduce infinite source");
     Optional<StorageType> accum;
     source | [&](Value v) {
-      if (accum.hasValue()) {
-        accum = reducer_(std::move(accum.value()), std::forward<Value>(v));
+      if (auto target = accum.get_pointer()) {
+        *target = reducer_(std::move(*target), std::forward<Value>(v));
       } else {
         accum = std::forward<Value>(v);
       }
@@ -1990,10 +1990,13 @@ class Min : public Operator<Min<Selector, Comparer>> {
     Optional<Key> minKey;
     source | [&](Value v) {
       Key key = selector_(asConst(v)); // so that selector_ cannot mutate v
-      if (!minKey.hasValue() || comparer_(key, minKey.value())) {
-        minKey = std::move(key);
-        min = std::forward<Value>(v);
+      if (auto lastKey = minKey.get_pointer()) {
+        if (!comparer_(key, *lastKey)) {
+          return;
+        }
       }
+      minKey = std::move(key);
+      min = std::forward<Value>(v);
     };
     return min;
   }