netdevice: Add missing parentheses in macro
authorBenjamin Poirier <bpoirier@suse.de>
Wed, 14 Jan 2015 07:52:35 +0000 (16:52 +0900)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Jan 2015 21:34:41 +0000 (16:34 -0500)
For example, one could conceivably call
for_each_netdev_in_bond_rcu(condition ? bond1 : bond2, slave)
and get an unexpected result.

Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h

index 7f794db8e486760c36b4a2ed61d184cc968fd2a0..52fd8e8694cfade5e844d52a70b191c3183f60a2 100644 (file)
@@ -2085,7 +2085,7 @@ extern rwlock_t                           dev_base_lock;          /* Device list lock */
        list_for_each_entry_continue_rcu(d, &(net)->dev_base_head, dev_list)
 #define for_each_netdev_in_bond_rcu(bond, slave)       \
                for_each_netdev_rcu(&init_net, slave)   \
-                       if (netdev_master_upper_dev_get_rcu(slave) == bond)
+                       if (netdev_master_upper_dev_get_rcu(slave) == (bond))
 #define net_device_entry(lh)   list_entry(lh, struct net_device, dev_list)
 
 static inline struct net_device *next_net_device(struct net_device *dev)