When we do the single-store optimization, delete both the store

and the alloca so they don't get reprocessed.

This speeds up PR1432 from 2.20s to 2.17s.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@40812 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
index 02eeb3cc0a42787663fe5550dbd2396984a8c94c..1106c6ea163bb70aafad71bdc3088ef8df89e131 100644 (file)
--- a/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
+++ b/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
@@ -290,9 +290,15 @@ void PromoteMem2Reg::run() {
 
       // Finally, after the scan, check to see if the store is all that is left.
       if (Info.UsingBlocks.empty()) {
-        ++NumSingleStore;
+        // Remove the (now dead) store and alloca.
+        Info.OnlyStore->eraseFromParent();
+        if (AST) AST->deleteValue(AI);
+        AI->eraseFromParent();
+        
         // The alloca has been processed, move on.
         RemoveFromAllocasList(AllocaNum);
+        
+        ++NumSingleStore;
         continue;
       }
     }
@@ -728,7 +734,7 @@ PromoteLocallyUsedAllocas(BasicBlock *BB, const std::vector<AllocaInst*> &AIs) {
         if (AIt != CurValues.end()) {
           // Store updates the "current value"...
           AIt->second = SI->getOperand(0);
-          BB->getInstList().erase(SI);
+          SI->eraseFromParent();
         }
       }
     }