[media] em28xx: add comment about Samsung and Kodak sensor probing addresses
authorFrank Schaefer <fschaefer.oss@googlemail.com>
Wed, 27 Mar 2013 20:06:35 +0000 (17:06 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 29 Mar 2013 09:40:47 +0000 (06:40 -0300)
The Windows driver also probes at least two further i2c addresses (0x22 >> 1
and 0x66 >> 1). I've got some hints that they are very likely used by Samsung
and Kodak sensors, which are known to be used in Empia devices, too.
We havn't seen any devices using these sensors yet and don't know how to probe
them properly, so leave a comment.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/em28xx/em28xx-camera.c

index e8b3322242c005ec844e45e15da18097e6cd1e4a..64b70d42da1eeec29bef6de0021c020d87cc2289 100644 (file)
@@ -301,6 +301,11 @@ int em28xx_detect_sensor(struct em28xx *dev)
        if (dev->em28xx_sensor == EM28XX_NOSENSOR && ret < 0)
                ret = em28xx_probe_sensor_omnivision(dev);
 
+       /*
+        * NOTE: the Windows driver also probes i2c addresses
+        *       0x22 (Samsung ?) and 0x66 (Kodak ?)
+        */
+
        if (dev->em28xx_sensor == EM28XX_NOSENSOR && ret < 0) {
                em28xx_info("No sensor detected\n");
                return -ENODEV;