mmc: sd: Add new CONFIG_MMC_PARANOID_SD_INIT for enabling retries during SD detection
authorSan Mehat <san@google.com>
Tue, 11 Nov 2008 17:35:36 +0000 (09:35 -0800)
committerColin Cross <ccross@android.com>
Thu, 30 Sep 2010 00:49:13 +0000 (17:49 -0700)
Signed-off-by: San Mehat <san@google.com>
drivers/mmc/core/Kconfig
drivers/mmc/core/sd.c

index bb22ffd76ef8a2bfba0bbdc29d73faabc51911bc..79e279528f968102b8f0c3635581fdca18a9749a 100644 (file)
@@ -16,3 +16,12 @@ config MMC_UNSAFE_RESUME
 
          This option sets a default which can be overridden by the
          module parameter "removable=0" or "removable=1".
+
+config MMC_PARANOID_SD_INIT
+       bool "Enable paranoid SD card initialization (EXPERIMENTAL)"
+       help
+         If you say Y here, the MMC layer will be extra paranoid
+         about re-trying SD init requests. This can be a useful
+         work-around for buggy controllers and hardware. Enable
+         if you are experiencing issues with SD detection.
+
index 0f5241085557488dbfb674a60474fe7709719d44..072c822d66b7b8904f33420ed47eb1879bd44af1 100644 (file)
@@ -402,6 +402,9 @@ struct device_type sd_type = {
 int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid)
 {
        int err;
+#ifdef CONFIG_MMC_PARANOID_SD_INIT
+       int retries;
+#endif
 
        /*
         * Since we're changing the OCR value, we seem to
@@ -481,7 +484,26 @@ int mmc_sd_setup_card(struct mmc_host *host, struct mmc_card *card,
                /*
                 * Fetch switch information from card.
                 */
+#ifdef CONFIG_MMC_PARANOID_SD_INIT
+               for (retries = 1; retries <= 3; retries++) {
+                       err = mmc_read_switch(card);
+                       if (!err) {
+                               if (retries > 1) {
+                                       printk(KERN_WARNING
+                                              "%s: recovered\n", 
+                                              mmc_hostname(host));
+                               }
+                               break;
+                       } else {
+                               printk(KERN_WARNING
+                                      "%s: read switch failed (attempt %d)\n",
+                                      mmc_hostname(host), retries);
+                       }
+               }
+#else
                err = mmc_read_switch(card);
+#endif
+
                if (err)
                        return err;
        }