staging: comedi: ni_at_a2150: fix an always true condition test
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 9 Dec 2013 18:32:58 +0000 (11:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Dec 2013 07:16:24 +0000 (23:16 -0800)
As pointed out by the kbuild test robot, and Ian Abbott, the dma >= 0 test
is always true because dma is unsigned. This generates a warn message:

drivers/staging/comedi/drivers/ni_at_a2150.c:715 a2150_attach()
  warn: always true condition '(dma >= 0) => (0-u32max >= 0)'

Fix the test as suggested by Ian Abbott.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_at_a2150.c

index 0876bc5c020937d750e0bc2c2f6efafa2334a1b2..0c71fdfecac209824c39473e3b12eeedddf1aa98 100644 (file)
@@ -712,7 +712,7 @@ static int a2150_attach(struct comedi_device *dev, struct comedi_devconfig *it)
                }
        }
 
-       if (dev->irq && ((dma >= 0 && dma <= 4) || (dma >= 5 && dma <= 7))) {
+       if (dev->irq && dma <= 7 && dma != 4) {
                ret = request_dma(dma, dev->board_name);
                if (ret == 0) {
                        devpriv->dma = dma;