PCI: Use PCI_EXP_SLTCAP_PSN mask when extracting slot number
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 9 Apr 2013 22:46:12 +0000 (16:46 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 15 Apr 2013 20:30:44 +0000 (14:30 -0600)
Use PCI_EXP_SLTCAP_PSN mask to make it easier to find where the
Physical Slot Number is used.

The Physical Slot Number is bits 31:19 of the Slot Capabilities Register,
and slot_cap is a u32, so the mask is technically unnecessary, but it's
helpful for human readers.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pciehp_acpi.c

index 24d709b7388c5c7440b157b98ffd8448eebbc6ab..ead7c534095e885572c85c6963d57742dcab7bec 100644 (file)
@@ -90,7 +90,7 @@ static int __init dummy_probe(struct pcie_device *dev)
        slot = kzalloc(sizeof(*slot), GFP_KERNEL);
        if (!slot)
                return -ENOMEM;
-       slot->number = slot_cap >> 19;
+       slot->number = (slot_cap & PCI_EXP_SLTCAP_PSN) >> 19;
        list_for_each_entry(tmp, &dummy_slots, list) {
                if (tmp->number == slot->number)
                        dup_slot_id++;