UBIFS: Delete unnecessary checks before the function call "iput"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 4 Nov 2015 19:00:42 +0000 (20:00 +0100)
committerRichard Weinberger <richard@nod.at>
Fri, 6 Nov 2015 22:26:52 +0000 (23:26 +0100)
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/recovery.c

index 2a1f0bc836be9df3398cf8a489a54be0a3bb4ec5..586d59347fff00c4572af57bf6e487f6fa2932d8 100644 (file)
@@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
        struct size_entry *e, *n;
 
        rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
-               if (e->inode)
-                       iput(e->inode);
+               iput(e->inode);
                kfree(e);
        }
 
@@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
                                err = fix_size_in_place(c, e);
                                if (err)
                                        return err;
-                               if (e->inode)
-                                       iput(e->inode);
+                               iput(e->inode);
                        }
                }