Replacing a cast with another one does not reduce the number of

casts in the input.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@40741 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp
index 806c6e4da9b0f9482201687517550e3af625edf6..e8430749206691731348eb49c386370ccb678a4f 100644 (file)
--- a/lib/Transforms/Scalar/InstructionCombining.cpp
+++ b/lib/Transforms/Scalar/InstructionCombining.cpp
@@ -6384,12 +6384,10 @@ static bool CanEvaluateInDifferentType(Value *V, const IntegerType *Ty,
   case Instruction::SExt:
   case Instruction::Trunc:
     // If this is the same kind of case as our original (e.g. zext+zext), we
-    // can safely eliminate it.
-    break;  // FIXME: This causes PR1594
-    if (I->getOpcode() == CastOpc) {
-      ++NumCastsRemoved;
+    // can safely replace it.  Note that replacing it does not reduce the number
+    // of casts in the input.
+    if (I->getOpcode() == CastOpc)
       return true;
-    }
     break;
   default:
     // TODO: Can handle more cases here.