sony-laptop: fix a couple signedness bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 9 Jun 2012 04:18:14 +0000 (13:18 +0900)
committerMatthew Garrett <mjg@redhat.com>
Tue, 26 Jun 2012 18:43:33 +0000 (14:43 -0400)
This needs to be signed to handle negative error codes.
Remove a redundant check, read_limits is always called with a valid
handle.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/sony-laptop.c

index 78e6389d2cae73d7441827e87b2c0aff1ffc5b94..b9499b65c1cd3816c7d55d17d4f29ba9c64ba153 100644 (file)
@@ -2139,7 +2139,7 @@ static ssize_t sony_nc_thermal_mode_show(struct device *dev,
                struct device_attribute *attr, char *buffer)
 {
        ssize_t count = 0;
-       unsigned int mode = sony_nc_thermal_mode_get();
+       int mode = sony_nc_thermal_mode_get();
 
        if (mode < 0)
                return mode;
@@ -2507,8 +2507,6 @@ static void sony_nc_backlight_ng_read_limits(int handle,
        props->maxlvl = 0xff;
 
        offset = sony_find_snc_handle(handle);
-       if (offset < 0)
-               return;
 
        /* try to read the boundaries from ACPI tables, if we fail the above
         * defaults should be reasonable