[media] staging: davinci_vpfe: fix error check
authorLevente Kurusa <levex@linux.com>
Sat, 15 Feb 2014 10:17:11 +0000 (07:17 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 28 Feb 2014 16:36:28 +0000 (13:36 -0300)
The check would check the pointer, which is never less than 0.
According to the error message, the correct check would be
to check the return value of ipipe_mode. Check that instead.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Levente Kurusa <levex@linux.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c

index 2d36b60bdbf166e369049e82ef2ce3f15de26f45..b2daf5e63f88da0297555afe0b52264747e79e92 100644 (file)
@@ -267,7 +267,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
        }
 
        ipipe_mode = get_ipipe_mode(ipipe);
-       if (ipipe < 0) {
+       if (ipipe_mode < 0) {
                pr_err("Failed to get ipipe mode");
                return -EINVAL;
        }