DRM: remove drm_pci_device_is_pcie
authorJon Mason <jdmason@kudzu.us>
Mon, 27 Jun 2011 16:07:50 +0000 (16:07 +0000)
committerDave Airlie <airlied@redhat.com>
Wed, 13 Jul 2011 07:14:52 +0000 (08:14 +0100)
drm_pci_device_is_pcie duplicates the funcationality of pci_is_pcie.
Convert callers of the former to the latter.  This has the side benefit
of removing an unnecessary search in the PCI configuration space due to
using a saved PCIe capability offset.

[airlied: update for new callsite]

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/nouveau/nouveau_mem.c
drivers/gpu/drm/nouveau/nouveau_sgdma.c
drivers/gpu/drm/nouveau/nouveau_state.c
drivers/gpu/drm/nouveau/nv04_instmem.c
drivers/gpu/drm/radeon/radeon_cp.c
drivers/gpu/drm/radeon/radeon_kms.c
include/drm/drmP.h

index 81dadeb9debc8ac9fe8029fc6255ee6c3e9791f6..f9ae2fc3d6f1f897b985ce9f363f8eeb04dd93a3 100644 (file)
@@ -397,7 +397,7 @@ nouveau_mem_vram_init(struct drm_device *dev)
                if (pci_dma_supported(dev->pdev, DMA_BIT_MASK(40)))
                        dma_bits = 40;
        } else
-       if (0 && drm_pci_device_is_pcie(dev) &&
+       if (0 && pci_is_pcie(dev->pdev) &&
            dev_priv->chipset  > 0x40 &&
            dev_priv->chipset != 0x45) {
                if (pci_dma_supported(dev->pdev, DMA_BIT_MASK(39)))
index 82fad914e648441340a836bf306d761d09afc904..c444cadbf849110e4d3b418397f26e9524670ca0 100644 (file)
@@ -429,7 +429,7 @@ nouveau_sgdma_init(struct drm_device *dev)
        u32 aper_size, align;
        int ret;
 
-       if (dev_priv->card_type >= NV_40 && drm_pci_device_is_pcie(dev))
+       if (dev_priv->card_type >= NV_40 && pci_is_pcie(dev->pdev))
                aper_size = 512 * 1024 * 1024;
        else
                aper_size = 64 * 1024 * 1024;
@@ -458,7 +458,7 @@ nouveau_sgdma_init(struct drm_device *dev)
                dev_priv->gart_info.type = NOUVEAU_GART_HW;
                dev_priv->gart_info.func = &nv50_sgdma_backend;
        } else
-       if (0 && drm_pci_device_is_pcie(dev) &&
+       if (0 && pci_is_pcie(dev->pdev) &&
            dev_priv->chipset > 0x40 && dev_priv->chipset != 0x45) {
                if (nv44_graph_class(dev)) {
                        dev_priv->gart_info.func = &nv44_sgdma_backend;
index 1d08875dc8a3cea24febe1fb65544063ee3506ea..20a38ca65a26a8daae247b8753ca557643a7ba85 100644 (file)
@@ -1111,7 +1111,7 @@ int nouveau_ioctl_getparam(struct drm_device *dev, void *data,
        case NOUVEAU_GETPARAM_BUS_TYPE:
                if (drm_pci_device_is_agp(dev))
                        getparam->value = NV_AGP;
-               else if (drm_pci_device_is_pcie(dev))
+               else if (pci_is_pcie(dev->pdev))
                        getparam->value = NV_PCIE;
                else
                        getparam->value = NV_PCI;
index e2075dec84a3b0997144928b71b028b4636aa5de..c1248e0740a304947a1170c0a822edd5f43ffe65 100644 (file)
@@ -42,7 +42,7 @@ int nv04_instmem_init(struct drm_device *dev)
                rsvd *= dev_priv->engine.fifo.channels;
 
                /* pciegart table */
-               if (drm_pci_device_is_pcie(dev))
+               if (pci_is_pcie(dev->pdev))
                        rsvd += 512 * 1024;
 
                /* object storage */
index 75867792a4e2cfee86426304b47b995372f4c00e..045ec59478f98210567375c9fa2d5a8c5f9493ac 100644 (file)
@@ -2115,7 +2115,7 @@ int radeon_driver_load(struct drm_device *dev, unsigned long flags)
 
        if (drm_pci_device_is_agp(dev))
                dev_priv->flags |= RADEON_IS_AGP;
-       else if (drm_pci_device_is_pcie(dev))
+       else if (pci_is_pcie(dev->pdev))
                dev_priv->flags |= RADEON_IS_PCIE;
        else
                dev_priv->flags |= RADEON_IS_PCI;
index bd58af658581b3d3672aa363f7e5c7418abaaefa..6f80a216bb39d68666f2bc4bc3ca3e4fe4d20c0b 100644 (file)
@@ -60,7 +60,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
        /* update BUS flag */
        if (drm_pci_device_is_agp(dev)) {
                flags |= RADEON_IS_AGP;
-       } else if (drm_pci_device_is_pcie(dev)) {
+       } else if (pci_is_pcie(dev->pdev)) {
                flags |= RADEON_IS_PCIE;
        } else {
                flags |= RADEON_IS_PCI;
index 4912cb75ae4c36857bc6df5c9ed5136f0b898fb5..d9c8c6c4639ac901bf0296bcb5dde525d96cb5f7 100644 (file)
@@ -1674,13 +1674,6 @@ static __inline__ int drm_pci_device_is_agp(struct drm_device *dev)
        return pci_find_capability(dev->pdev, PCI_CAP_ID_AGP);
 }
 
-
-static __inline__ int drm_pci_device_is_pcie(struct drm_device *dev)
-{
-       return pci_find_capability(dev->pdev, PCI_CAP_ID_EXP);
-}
-
-
 extern int drm_pci_init(struct drm_driver *driver, struct pci_driver *pdriver);
 extern void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver);
 extern int drm_get_pci_dev(struct pci_dev *pdev,