[media] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Mon, 24 Sep 2012 09:11:03 +0000 (06:11 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 6 Oct 2012 12:18:10 +0000 (09:18 -0300)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

[mchehab@redhat.com: Second hunk removed, as it doesn't apply anymore,
 due to a merge conflict]
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/soc_camera/mx2_camera.c

index 8d2587137d3bb9845c6e932194c583ac901638dd..9fd9d1c5b218a5b51ff0522b9969db06e795706c 100644 (file)
@@ -1655,6 +1655,7 @@ static int __devinit mx27_camera_emma_init(struct platform_device *pdev)
        irq_emma = platform_get_irq(pdev, 1);
        if (!res_emma || !irq_emma) {
                dev_err(pcdev->dev, "no EMMA resources\n");
+               err = -ENODEV;
                goto out;
        }