[NET]: Can use __get_cpu_var() instead of per_cpu() in loopback driver.
authorEric Dumazet <dada1@cosmosbay.com>
Fri, 20 Oct 2006 07:32:41 +0000 (00:32 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Oct 2006 07:32:41 +0000 (00:32 -0700)
As BHs are off in loopback_xmit(), preemption cannot occurs, so we can
use __get_cpu_var() instead of per_cpu() (and avoid a
preempt_enable()/preempt_disable() pair)

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/loopback.c

index 93fbea1c9271ec4562a6e826367853f21011b101..82c10dec1b5ac9d739578aa4d4874573d4ad11c4 100644 (file)
@@ -153,14 +153,14 @@ static int loopback_xmit(struct sk_buff *skb, struct net_device *dev)
 #endif
        dev->last_rx = jiffies;
 
-       lb_stats = &per_cpu(pcpu_lstats, get_cpu());
+       /* it's OK to use __get_cpu_var() because BHs are off */
+       lb_stats = &__get_cpu_var(pcpu_lstats);
        lb_stats->bytes += skb->len;
        lb_stats->packets++;
-       put_cpu();
 
        netif_rx(skb);
 
-       return(0);
+       return 0;
 }
 
 static struct net_device_stats loopback_stats;