[SymbolSize] Skip sorting by index, just assign by index.
authorBenjamin Kramer <benny.kra@googlemail.com>
Mon, 29 Jun 2015 16:05:00 +0000 (16:05 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Mon, 29 Jun 2015 16:05:00 +0000 (16:05 +0000)
No functional change intended.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@240961 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Object/SymbolSize.cpp

index 730e54cf33052087d98fe4872aa8e35a74365e3c..1d5cd78e6d9cb587dbcb16d71fa563cf712abb8c 100644 (file)
@@ -31,10 +31,6 @@ static int compareAddress(const SymEntry *A, const SymEntry *B) {
   return A->Address - B->Address;
 }
 
-static int compareNumber(const SymEntry *A, const SymEntry *B) {
-  return A->Number - B->Number;
-}
-
 static unsigned getSectionID(const ObjectFile &O, SectionRef Sec) {
   if (auto *M = dyn_cast<MachOObjectFile>(&O))
     return M->getSectionID(Sec);
@@ -93,12 +89,12 @@ llvm::object::computeSymbolSizes(const ObjectFile &O) {
     P.Address = Size;
   }
 
-  // Put back in the original order and copy the result
-  array_pod_sort(Addresses.begin(), Addresses.end(), compareNumber);
+  // Assign the sorted symbols in the original order.
+  Ret.resize(SymNum);
   for (SymEntry &P : Addresses) {
     if (P.I == O.symbol_end())
       continue;
-    Ret.push_back({*P.I, P.Address});
+    Ret[P.Number] = {*P.I, P.Address};
   }
   return Ret;
 }