Revert D4567233: [Folly] Drop support for Clang < 3.9

Summary: This reverts commit cd94c711f0390d249b6736ab292721a477022b02

Differential Revision: D4567233

fbshipit-source-id: a10aff6b4c231666aec9f40ab65e881c3cd870dc

diff --git a/folly/Range.h b/folly/Range.h
index ca3731e11c5915a542e9c0e223f751714db46328..f80e635de58d5686ff59b0115070a8c72a492da8 100644 (file)
--- a/folly/Range.h
+++ b/folly/Range.h
@@ -206,7 +206,9 @@ public:
   constexpr Range(Iter start, size_t size)
       : b_(start), e_(start + size) { }
 
+# if !__clang__ || __CLANG_PREREQ(3, 7) // Clang 3.6 crashes on this line
   /* implicit */ Range(std::nullptr_t) = delete;
+# endif
 
   template <class T = Iter, typename detail::IsCharPointer<T>::type = 0>
   constexpr /* implicit */ Range(Iter str)

diff --git a/folly/test/ExpectedTest.cpp b/folly/test/ExpectedTest.cpp
index da2ede70ccc73cbbcde583aa35ab9c0313a5b39b..d8291d0f39c2fefc52547ff8b37f311b623b8801 100644 (file)
--- a/folly/test/ExpectedTest.cpp
+++ b/folly/test/ExpectedTest.cpp
@@ -15,6 +15,7 @@
  */
 
 #include <folly/Expected.h>
+#include <folly/Portability.h>
 #include <folly/portability/GTest.h>
 
 #include <algorithm>
@@ -452,7 +453,7 @@ TEST(Expected, MakeOptional) {
   EXPECT_EQ(**exIntPtr, 3);
 }
 
-#if __clang__
+#if __CLANG_PREREQ(3, 6)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wself-move"
 #endif
@@ -467,7 +468,7 @@ TEST(Expected, SelfAssignment) {
   ASSERT_TRUE(b.hasValue() && b.value() == "23333333");
 }
 
-#if __clang__
+#if __CLANG_PREREQ(3, 6)
 #pragma clang diagnostic pop
 #endif
 

diff --git a/folly/test/OptionalTest.cpp b/folly/test/OptionalTest.cpp
index 5243e5e55a44388c48223a1e5db3e76e3df8688f..ed84f753f9608e7cf3aa82c6e44d39aa9f121582 100644 (file)
--- a/folly/test/OptionalTest.cpp
+++ b/folly/test/OptionalTest.cpp
@@ -15,6 +15,7 @@
  */
 
 #include <folly/Optional.h>
+#include <folly/Portability.h>
 #include <folly/portability/GTest.h>
 
 #include <algorithm>
@@ -520,7 +521,7 @@ TEST(Optional, MakeOptional) {
   EXPECT_EQ(**optIntPtr, 3);
 }
 
-#if __clang__
+#if __CLANG_PREREQ(3, 6)
 # pragma clang diagnostic push
 # pragma clang diagnostic ignored "-Wself-move"
 #endif
@@ -535,7 +536,7 @@ TEST(Optional, SelfAssignment) {
   ASSERT_TRUE(b.hasValue() && b.value() == 23333333);
 }
 
-#if __clang__
+#if __CLANG_PREREQ(3, 6)
 # pragma clang diagnostic pop
 #endif