target: Release se_cmd when LUN lookup fails for TMR
authorRoland Dreier <roland@purestorage.com>
Wed, 2 Jan 2013 20:47:59 +0000 (12:47 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 11 Jan 2013 05:00:36 +0000 (21:00 -0800)
When transport_lookup_tmr_lun() fails and we return a task management
response from target_complete_tmr_failure(), we need to call
transport_cmd_check_stop_to_fabric() to release the last ref to the
cmd after calling se_tfo->queue_tm_rsp(), or else we will never remove
the failed TMR from the session command list (and we'll end up waiting
forever when trying to tear down the session).

(nab: Fix minor compile breakage)

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c

index 489bd1678d87636716dd7493c26a67f88a53ba48..bd587b70661a0ce11f6aaab596f4e46c6ee14c7e 100644 (file)
@@ -1393,6 +1393,8 @@ static void target_complete_tmr_failure(struct work_struct *work)
 
        se_cmd->se_tmr_req->response = TMR_LUN_DOES_NOT_EXIST;
        se_cmd->se_tfo->queue_tm_rsp(se_cmd);
+
+       transport_cmd_check_stop_to_fabric(se_cmd);
 }
 
 /**