Staging: wilc1000: Boolean tests don't need comparisons
authorAbdul Hussain <habdul@visteon.com>
Tue, 16 Jun 2015 09:44:06 +0000 (09:44 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jun 2015 02:23:25 +0000 (19:23 -0700)
This patch removes unwanted true and false from boolean tests.

Signed-off-by: Abdul Hussain <habdul@visteon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/coreconfigurator.c
drivers/staging/wilc1000/linux_mon.c
drivers/staging/wilc1000/linux_wlan.c
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
drivers/staging/wilc1000/wilc_wlan.c

index bbb32318b2c393bea398599be1276958086208a6..523c863b22ac9e2176c461defb85f75d5a42adcd 100644 (file)
@@ -1716,7 +1716,7 @@ s32 ParseResponse(u8 *resp, tstrWID *pstrWIDcfgResult)
                        idx++;
                }
                idx += 3;
-               if ((u16WIDid == g_wid_num) && (num_wid_processed == false)) {
+               if ((u16WIDid == g_wid_num) && (!num_wid_processed)) {
                        num_wid_processed = true;
 
                        if (-2 == further_process_response(&resp[idx], u16WIDid, cfg_len, true, 0, &pstrWIDcfgResult[ResCnt])) {
@@ -1922,7 +1922,7 @@ s32 ConfigWaitResponse(char *pcRespBuffer, s32 s32MaxRespBuffLen, s32 *ps32Bytes
         * gstrConfigPktInfo.bRespRequired = bRespRequired;*/
 
 
-       if (gstrConfigPktInfo.bRespRequired == true) {
+       if (gstrConfigPktInfo.bRespRequired) {
                down(&SemHandlePktResp);
 
                *ps32BytesRead = gstrConfigPktInfo.s32BytesRead;
@@ -1983,7 +1983,7 @@ s32 SendConfigPkt(u8 u8Mode, tstrWID *pstrWIDs,
        ConfigWaitResponse(gps8ConfigPacket, MAX_PACKET_BUFF_SIZE, &s32RcvdRespLen, bRespRequired);
 
 
-       if (bRespRequired == true)      {
+       if (bRespRequired)      {
                /* If the operating Mode is GET, then we expect a response frame from */
                /* the driver. Hence start listening to the port for response         */
                if (g_oper_mode == GET_CFG) {
@@ -2020,7 +2020,7 @@ s32 ConfigProvideResponse(char *pcRespBuffer, s32 s32RespLen)
 {
        s32 s32Error = WILC_SUCCESS;
 
-       if (gstrConfigPktInfo.bRespRequired == true) {
+       if (gstrConfigPktInfo.bRespRequired) {
                if (s32RespLen <= gstrConfigPktInfo.s32MaxRespBuffLen) {
                        WILC_memcpy(gstrConfigPktInfo.pcRespBuffer, pcRespBuffer, s32RespLen);
                        gstrConfigPktInfo.s32BytesRead = s32RespLen;
index bc7feb459a7ae70c928644f263fd24b9cecf2219..aaac9a08fe6424da8c019672024018f76f35ff8d 100644 (file)
@@ -452,7 +452,7 @@ void WILC_mgm_HOSTAPD_ACK(void *priv, bool bStatus)
                cb_hdr->rate = 5; /* txrate->bitrate / 5; */
 
 
-               if (true == bStatus) {
+               if (bStatus) {
                        /* success */
                        cb_hdr->tx_flags = IEEE80211_RADIOTAP_F_TX_RTS;
                } else {
index c1e92722a4715dd4f034d9f269f47182469e26c5..c1cf5be312a4de13f68c3dbd91ba04631ff2c0db 100644 (file)
@@ -309,7 +309,7 @@ static int dev_state_ev_handler(struct notifier_block *this, unsigned long event
 
 
 
-               if (bEnablePS    == true)
+               if (bEnablePS)
                        host_int_set_power_mgmt((WILC_WFIDrvHandle)pstrWFIDrv, 1, 0);
 
                PRINT_D(GENERIC_DBG, "[%s] Up IP\n", dev_iface->ifa_label);
index 9dcb3268d20cee8f5cfd919251b5ac3bf21e6e0c..92064db9eb05589a37127e97c5bd0a715087bf9c 100644 (file)
@@ -624,7 +624,7 @@ static void CfgConnectResult(tenuConnDisconnEvent enuConnDisconnEvent,
                                }
                        }
 
-                       if (bNeedScanRefresh == true) {
+                       if (bNeedScanRefresh) {
                                /*BugID_5418*/
                                /*Also, refrsh DIRECT- results if */
                                refresh_scan(priv, 1, true);
@@ -2817,7 +2817,7 @@ int WILC_WFI_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
                return -EIO;
        }
 
-       if (bEnablePS    == true)
+       if (bEnablePS)
                host_int_set_power_mgmt(priv->hWILCWFIDrv, enabled, timeout);
 
 
index 762470c4e0523b341e8cdd2ce725918c85f1bf2a..db9e7173c957696c9ad8c1b90d19e3007dfb1af3 100644 (file)
@@ -559,7 +559,7 @@ static int wilc_wlan_txq_add_net_pkt(void *priv, uint8_t *buffer, uint32_t buffe
 #ifdef TCP_ACK_FILTER
        tqe->tcp_PendingAck_index = NOT_TCP_ACK;
 #ifdef TCP_ENHANCEMENTS
-       if (is_TCP_ACK_Filter_Enabled() == true)
+       if (is_TCP_ACK_Filter_Enabled())
 #endif
        tcp_process(tqe);
 #endif
@@ -2337,7 +2337,7 @@ u16 Set_machw_change_vir_if(bool bValue)
                PRINT_ER("Error while Reading reg WILC_CHANGING_VIR_IF\n");
        }
 
-       if (bValue == true) {
+       if (bValue) {
                reg |= (BIT31);
        } else {
                reg &= ~(BIT31);