proc: proc_init_inodecache() can't fail
authorAlexey Dobriyan <adobriyan@gmail.com>
Thu, 16 Oct 2008 23:43:55 +0000 (03:43 +0400)
committerAlexey Dobriyan <adobriyan@gmail.com>
Thu, 23 Oct 2008 09:27:50 +0000 (13:27 +0400)
kmem_cache creation code will panic, don't return anything.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
fs/proc/inode.c
fs/proc/internal.h
fs/proc/root.c

index c6b4fa7e3b49e9a2625bf3a76465c85d7df7eba2..2543fd00c6589cc8218169f16b0214de9c063f81 100644 (file)
@@ -106,14 +106,13 @@ static void init_once(void *foo)
        inode_init_once(&ei->vfs_inode);
 }
 
-int __init proc_init_inodecache(void)
+void __init proc_init_inodecache(void)
 {
        proc_inode_cachep = kmem_cache_create("proc_inode_cache",
                                             sizeof(struct proc_inode),
                                             0, (SLAB_RECLAIM_ACCOUNT|
                                                SLAB_MEM_SPREAD|SLAB_PANIC),
                                             init_once);
-       return 0;
 }
 
 static const struct super_operations proc_sops = {
index 3bfb7b8747b3f027657a217a18ff0a7bc37b6f5d..d5bf4dec6b0a83e54bc3447705dbf589307ec873 100644 (file)
@@ -66,7 +66,7 @@ extern const struct inode_operations proc_net_inode_operations;
 
 void free_proc_entry(struct proc_dir_entry *de);
 
-int proc_init_inodecache(void);
+void proc_init_inodecache(void);
 
 static inline struct pid *proc_pid(struct inode *inode)
 {
index 95117538a4f6fd3b4fdc90558127caa282d7e800..2a3abd25b30b38290c09f7d7d166c78a4cdead73 100644 (file)
@@ -104,9 +104,9 @@ static struct file_system_type proc_fs_type = {
 
 void __init proc_root_init(void)
 {
-       int err = proc_init_inodecache();
-       if (err)
-               return;
+       int err;
+
+       proc_init_inodecache();
        err = register_filesystem(&proc_fs_type);
        if (err)
                return;