at86rf230: detailed edge triggered irq warning
authorAlexander Aring <alex.aring@gmail.com>
Thu, 27 Aug 2015 19:49:20 +0000 (21:49 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 17 Sep 2015 11:20:05 +0000 (13:20 +0200)
This patch introduce a more detailed information why edge triggered
irq's are currently not recommended. It could be that rising/falling
edge detection can happen while the irq is disabled.

Suggested-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/net/ieee802154/at86rf230.c

index 19c16b97659ce57f7e3a1ffad5f6be2faaf1588c..b8b0628dc2f3707b11906f14da61132fa12332ef 100644 (file)
@@ -1376,7 +1376,7 @@ static int at86rf230_hw_init(struct at86rf230_local *lp, u8 xtal_trim)
        if (irq_type == IRQ_TYPE_EDGE_RISING ||
            irq_type == IRQ_TYPE_EDGE_FALLING)
                dev_warn(&lp->spi->dev,
-                        "Using edge triggered irq's are not recommended!\n");
+                        "Using edge triggered irq's are not recommended, because it can cause races and result in a non-functional driver!\n");
        if (irq_type == IRQ_TYPE_EDGE_FALLING ||
            irq_type == IRQ_TYPE_LEVEL_LOW)
                irq_pol = IRQ_ACTIVE_LOW;