misc: sram: fix error path in sram_probe
authorHeiko Stübner <heiko@sntech.de>
Fri, 5 Jul 2013 12:40:53 +0000 (14:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2013 05:54:50 +0000 (22:54 -0700)
The pool is created thru devm_gen_pool_create, so the call to
gen_pool_destroy is not necessary.
Instead the sram-clock must be turned off again if it exists.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Ulrich Prinz <ulrich.prinz@googlemail.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/sram.c

index d87cc91bc016568032c7416619c007d1995a6d54..afe66571ce0b7bfde98f05a1a75175f250482fa5 100644 (file)
@@ -68,7 +68,8 @@ static int sram_probe(struct platform_device *pdev)
        ret = gen_pool_add_virt(sram->pool, (unsigned long)virt_base,
                                res->start, size, -1);
        if (ret < 0) {
-               gen_pool_destroy(sram->pool);
+               if (sram->clk)
+                       clk_disable_unprepare(sram->clk);
                return ret;
        }