p54usb: bring first generation devices back to life
authorChristian Lamparter <chunkeey@web.de>
Wed, 17 Dec 2008 11:04:43 +0000 (12:04 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 19 Dec 2008 20:23:47 +0000 (15:23 -0500)
This patch fixes a serious regression (introduced by:
"p54: fix memory management")
that affected isl3886+net2280 usb devices operation.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Tested-by: Artur Skawina <art.08.09@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/p54usb.c

index 17f89c7eb098c38c2902e1353c55110520d5a79f..c44a200059d21c4ce0aae4a6f66b2e61af73984e 100644 (file)
@@ -301,6 +301,8 @@ static void p54u_tx_net2280(struct ieee80211_hw *dev, struct sk_buff *skb)
        struct net2280_tx_hdr *hdr;
        struct net2280_reg_write *reg;
        int err = 0;
+       __le32 addr = ((struct p54_hdr *) skb->data)->req_id;
+       __le16 len = cpu_to_le16(skb->len);
 
        reg = kmalloc(sizeof(*reg), GFP_ATOMIC);
        if (!reg)
@@ -325,8 +327,8 @@ static void p54u_tx_net2280(struct ieee80211_hw *dev, struct sk_buff *skb)
 
        hdr = (void *)skb_push(skb, sizeof(*hdr));
        memset(hdr, 0, sizeof(*hdr));
-       hdr->device_addr = ((struct p54_hdr *)skb->data)->req_id;
-       hdr->len = cpu_to_le16(skb->len + sizeof(struct p54_hdr));
+       hdr->len = len;
+       hdr->device_addr = addr;
 
        usb_fill_bulk_urb(int_urb, priv->udev,
                usb_sndbulkpipe(priv->udev, P54U_PIPE_DEV), reg, sizeof(*reg),