ath10k: improve 'hard' simulate fw crash
authorBen Greear <greearb@candelatech.com>
Fri, 25 Jul 2014 08:56:40 +0000 (11:56 +0300)
committerKalle Valo <kvalo@qca.qualcomm.com>
Mon, 28 Jul 2014 19:39:11 +0000 (22:39 +0300)
Different firmware may support different numbers of
vdevs.  Use value that is always out of range for all
firmware.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/debug.c

index 3030158c478e86cd9ee193af14b29da614f0d168..c9e35c87edfb651efcee1d72fff077dd9daa66eb 100644 (file)
@@ -531,7 +531,10 @@ static ssize_t ath10k_write_simulate_fw_crash(struct file *file,
                ret = ath10k_wmi_force_fw_hang(ar, WMI_FORCE_FW_HANG_ASSERT, 0);
        } else if (!strcmp(buf, "hard")) {
                ath10k_info("simulating hard firmware crash\n");
-               ret = ath10k_wmi_vdev_set_param(ar, TARGET_NUM_VDEVS + 1,
+               /* 0x7fff is vdev id, and it is always out of range for all
+                * firmware variants in order to force a firmware crash.
+                */
+               ret = ath10k_wmi_vdev_set_param(ar, 0x7fff,
                                        ar->wmi.vdev_param->rts_threshold, 0);
        } else {
                ret = -EINVAL;