Staging: sm7xx: preferred form for passing a size to memory allocation routines
authoranish kumar <anish198519851985@gmail.com>
Thu, 19 May 2011 15:28:51 +0000 (20:58 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 19 May 2011 22:34:32 +0000 (15:34 -0700)
The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
Please refer Documentation/Codingstyle chapter 14

Signed-off-by: anish kumar <anish198519851985@gmail.com>
Acked-by: Harry Wei <harryxiyou@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/sm7xx/smtcfb.c

index 1aca0cb40cafcf33a4cbc0c1e8135b00e7715b2e..c41d2f71a79cade45c36cdeb04ec37d0ff77813d 100644 (file)
@@ -714,7 +714,7 @@ static struct smtcfb_info *smtc_alloc_fb_info(struct pci_dev *dev,
 {
        struct smtcfb_info *sfb;
 
-       sfb = kzalloc(sizeof(struct smtcfb_info), GFP_KERNEL);
+       sfb = kzalloc(sizeof(*sfb), GFP_KERNEL);
 
        if (!sfb)
                return NULL;