stylistic change to MCSectionCOFF::PrintSwitchToSection COMDAT handling

Made a stylistic changed to the code/comments related to the unsupported COMDAT selection  type IMAGE_COMDAT_SELECT_LARGEST based on from Anton Korobeynikov.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103590 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/MC/MCSectionCOFF.cpp b/lib/MC/MCSectionCOFF.cpp
index 786bc7bc03562ef347f145c215171e90c8a69af8..d57bb0cd52b046cab7eb3a5c31d51afa7fe378aa 100644 (file)
--- a/lib/MC/MCSectionCOFF.cpp
+++ b/lib/MC/MCSectionCOFF.cpp
@@ -50,9 +50,6 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI,
   
   if (getCharacteristics() & MCSectionCOFF::IMAGE_SCN_LNK_COMDAT) {
     switch (Selection) {
-      default:
-        assert (0 && "unsupported COFF selection type");
-        break;
       case IMAGE_COMDAT_SELECT_NODUPLICATES:
         OS << "\t.linkonce one_only\n";
         break;
@@ -65,12 +62,15 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI,
       case IMAGE_COMDAT_SELECT_EXACT_MATCH:
         OS << "\t.linkonce same_contents\n";
         break;
-      // ".linkonce largest" is not documented as being an option.
-      // It seems odd that a link attribute designed essentially for PE/COFF
-      // wouldn't support all the options (at least as of binutils 2.20)
-    //case IMAGE_COMDAT_SELECT_LARGEST:
+    //NOTE: as of binutils 2.20, there is no way to specifiy select largest
+    //      with the .linkonce directive. For now, we treat it as an invalid
+    //      comdat selection value.
+      case IMAGE_COMDAT_SELECT_LARGEST:
     //  OS << "\t.linkonce largest\n";
     //  break;
+      default:
+        assert (0 && "unsupported COFF selection type");
+        break;
     }
   }
 }