mISDN: positive error return should be negative in mode_hfcmulti()
authorRoel Kluin <roel.kluin@gmail.com>
Tue, 2 Feb 2010 12:43:47 +0000 (12:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 4 Feb 2010 04:16:48 +0000 (20:16 -0800)
The error return should be negative.  Its only caller that acts upon its
return, handle_bmsg(), transmits the positive error but can also return
negative errors.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/hfcmulti.c

index 1a1420d7a828e9896c4b263e4eae10b266d65fa6..ad36df9b759ca614a922a893e85c9e43aabf1806 100644 (file)
@@ -2846,7 +2846,7 @@ mode_hfcmulti(struct hfc_multi *hc, int ch, int protocol, int slot_tx,
        int conf;
 
        if (ch < 0 || ch > 31)
-               return EINVAL;
+               return -EINVAL;
        oslot_tx = hc->chan[ch].slot_tx;
        oslot_rx = hc->chan[ch].slot_rx;
        conf = hc->chan[ch].conf;