CIFS: remove an unneeded NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 30 Apr 2015 14:30:24 +0000 (17:30 +0300)
committerSteve French <smfrench@gmail.com>
Wed, 20 May 2015 16:36:16 +0000 (11:36 -0500)
Smatch complains because we dereference "ses->server" without checking
some lines earlier inside the call to get_next_mid(ses->server).

fs/cifs/cifssmb.c:4921 CIFSGetDFSRefer()
warn: variable dereferenced before check 'ses->server' (see line 4899)

There is only one caller for this function get_dfs_path() and it always
passes a non-null "ses->server" pointer so this NULL check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/cifssmb.c

index 1091affba425dc69247db0fe9d74f3f9b0cd8612..f26ffbfc64d8b4eca26b8e8101f705043fc7a4a0 100644 (file)
@@ -4918,7 +4918,7 @@ getDFSRetry:
                strncpy(pSMB->RequestFileName, search_name, name_len);
        }
 
-       if (ses->server && ses->server->sign)
+       if (ses->server->sign)
                pSMB->hdr.Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
 
        pSMB->hdr.Uid = ses->Suid;