ALSA: hda - Pass printf argument directly to request_module()

request_module() handles the printf style arguments, so we don't have
to render strings in the caller side.  Not only it reduces the
unnecessary temporary string buffer, it's even safer from the security
POV.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 259fbeaa37bd35b2b887dbe6c08fc0ce540bdf24..0025bf4c2f44ba92d0c4084053c153c0128edb6f 100644 (file)
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -966,14 +966,12 @@ find_codec_preset(struct hda_codec *codec)
        mutex_unlock(&preset_mutex);
 
        if (mod_requested < HDA_MODREQ_MAX_COUNT) {
-               char name[32];
                if (!mod_requested)
-                       snprintf(name, sizeof(name), "snd-hda-codec-id:%08x",
-                                codec->vendor_id);
+                       request_module("snd-hda-codec-id:%08x",
+                                      codec->vendor_id);
                else
-                       snprintf(name, sizeof(name), "snd-hda-codec-id:%04x*",
-                                (codec->vendor_id >> 16) & 0xffff);
-               request_module(name);
+                       request_module("snd-hda-codec-id:%04x*",
+                                      (codec->vendor_id >> 16) & 0xffff);
                mod_requested++;
                goto again;
        }