projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b13ff56
)
misc: max9635: unregister upon probe failure
author
Sergey Kudakov
<sergey.kudakov@motorola.com>
Fri, 21 Jan 2011 01:08:12 +0000
(19:08 -0600)
committer
Rebecca Schultz Zavin
<rebecca@android.com>
Tue, 25 Jan 2011 23:58:27 +0000
(15:58 -0800)
currently it only unregisters input device but
not misc as a result in case if probe() fails
it may cause a panic in ubsequently called ioctl
where it would try to access unitialized/freed data
Signed-off-by: Sergey Kudakov <sergey.kudakov@motorola.com>
drivers/misc/max9635.c
patch
|
blob
|
history
diff --git
a/drivers/misc/max9635.c
b/drivers/misc/max9635.c
index 93f806229103887f15ca58749371effac8da0ea8..bcafebedd51dcb67032f6c76dde3393298f3efb4 100644
(file)
--- a/
drivers/misc/max9635.c
+++ b/
drivers/misc/max9635.c
@@
-548,6
+548,7
@@
err_req_irq_failed:
err_reg_init_failed:
input_unregister_device(als_data->idev);
error_input_register_failed:
+ misc_deregister(&max9635_misc_device);
error_misc_register_failed:
input_free_device(als_data->idev);
error_input_allocate_failed: