staging/crystalhd: unregister chardev when class_create fails in chd_dec_init_chdev
authorDevendra Naga <develkernel412222@gmail.com>
Sun, 5 Aug 2012 21:14:56 +0000 (02:59 +0545)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Aug 2012 02:15:49 +0000 (19:15 -0700)
we missed a unregiser_chrdev if the class_create and subsequent function calls / checks fail

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/crystalhd/crystalhd_lnx.c

index 0582ac04b75c929ba5aa89c441edc65e8b4cddef..5909d8d1b4d54b375b3018c15934e007646d2059 100644 (file)
@@ -375,7 +375,7 @@ static int __devinit chd_dec_init_chdev(struct crystalhd_adp *adp)
        if (IS_ERR(crystalhd_class)) {
                rc = PTR_ERR(crystalhd_class);
                BCMLOG_ERR("failed to create class\n");
-               goto fail;
+               goto class_create_fail;
        }
 
        dev = device_create(crystalhd_class, NULL, MKDEV(adp->chd_dec_major, 0),
@@ -412,6 +412,8 @@ elem_pool_fail:
        device_destroy(crystalhd_class, MKDEV(adp->chd_dec_major, 0));
 device_create_fail:
        class_destroy(crystalhd_class);
+class_create_fail:
+       unregister_chrdev(adp->chd_dec_major, CRYSTALHD_API_NAME);
 fail:
        return rc;
 }