arm: perf: use IDR types for CPU PMUs
authorMark Rutland <mark.rutland@arm.com>
Wed, 12 Sep 2012 09:53:23 +0000 (10:53 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 30 Oct 2014 12:16:59 +0000 (12:16 +0000)
For systems with heterogeneous CPUs (e.g. big.LITTLE systems) the PMUs
can be different in each cluster, and not all events can be migrated
between clusters. To allow userspace to deal with this, it must be
possible to address each PMU independently.

This patch changes PMUs to be registered with dynamic (IDR) types,
allowing them to be targeted individually. Each PMU's type can be found
in ${SYSFS_ROOT}/bus/event_source/devices/${PMU_NAME}/type.

From userspace, raw events can be targeted at a specific PMU:
$ perf stat -e ${PMU_NAME}/config=V,config1=V1,.../

Doing this does not break existing tools which use existing perf types:
when perf core can't find a PMU of matching type (in perf_init_event)
it'll iterate over the set of all PMUs. If a compatible PMU exists,
it'll be found eventually. If more than one compatible PMU exists, the
event will be handled by whichever PMU happens to be earlier in the pmus
list (which currently will be the last compatible PMU registered).

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/kernel/perf_event.c
arch/arm/kernel/perf_event_cpu.c

index ae96b986d50f480a3d17615a9dc9d9c3cd86d6c8..7ffb267fb6288dde4f634ced4e68b42cb6113aca 100644 (file)
@@ -77,8 +77,12 @@ armpmu_map_event(struct perf_event *event,
                 u32 raw_event_mask)
 {
        u64 config = event->attr.config;
+       int type = event->attr.type;
 
-       switch (event->attr.type) {
+       if (type == event->pmu->type)
+               return armpmu_map_raw_event(raw_event_mask, config);
+
+       switch (type) {
        case PERF_TYPE_HARDWARE:
                return armpmu_map_hw_event(event_map, config);
        case PERF_TYPE_HW_CACHE:
index e7d265210f2760aaa22172960c3085bd20c8ba42..7677d73cccc825168c4177061a1a07b36e188067 100644 (file)
@@ -311,7 +311,7 @@ static int cpu_pmu_device_probe(struct platform_device *pdev)
        }
 
        cpu_pmu_init(cpu_pmu);
-       ret = armpmu_register(cpu_pmu, PERF_TYPE_RAW);
+       ret = armpmu_register(cpu_pmu, -1);
 
        if (!ret)
                return 0;