usb: dwc3: gadget: clear stall when disabling endpoint
authorFelipe Balbi <balbi@ti.com>
Wed, 16 Apr 2014 15:30:33 +0000 (10:30 -0500)
committerFelipe Balbi <balbi@ti.com>
Wed, 16 Apr 2014 15:30:33 +0000 (10:30 -0500)
so it seems like DWC3 IP doesn't clear stalls
automatically when we disable an endpoint, because
of that, we _must_ make sure stalls are cleared
before clearing the proper bit in DALEPENA register.

Cc: <stable@vger.kernel.org> # v3.4+
Reported-by: Johannes Stezenbach <js@sig21.net>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/gadget.c

index a740eac74d56d502675107f03ffbd324e85f1f63..f0dc0ee85dedbf9c669e19293779f9fbfa8f9530 100644 (file)
@@ -608,6 +608,10 @@ static int __dwc3_gadget_ep_disable(struct dwc3_ep *dep)
 
        dwc3_remove_requests(dwc, dep);
 
+       /* make sure HW endpoint isn't stalled */
+       if (dep->flags & DWC3_EP_STALL)
+               __dwc3_gadget_ep_set_halt(dep, 0);
+
        reg = dwc3_readl(dwc->regs, DWC3_DALEPENA);
        reg &= ~DWC3_DALEPENA_EP(dep->number);
        dwc3_writel(dwc->regs, DWC3_DALEPENA, reg);