Do not set WriteFlags::WRITE_MSG_ZEROCOPY if the buffer ! isManaged()

Summary: Do not set WriteFlags::WRITE_MSG_ZEROCOPY if the buffer isShared()

Reviewed By: yfeldblum

Differential Revision: D6068711

fbshipit-source-id: fff14dcd4fcb20c9dbb60794420845042518922c

diff --git a/folly/io/async/AsyncSocket.cpp b/folly/io/async/AsyncSocket.cpp
index 7347dc6890279d65b0cd9373ce9b4fe18579d2a9..991b225c13ed57c84ce70471779104039913d4c5 100644 (file)
--- a/folly/io/async/AsyncSocket.cpp
+++ b/folly/io/async/AsyncSocket.cpp
@@ -861,7 +861,8 @@ bool AsyncSocket::isZeroCopyRequest(WriteFlags flags) {
 void AsyncSocket::adjustZeroCopyFlags(
     folly::IOBuf* buf,
     folly::WriteFlags& flags) {
-  if (zeroCopyEnabled_ && zeroCopyWriteChainThreshold_ && buf) {
+  if (zeroCopyEnabled_ && zeroCopyWriteChainThreshold_ && buf &&
+      buf->isManaged()) {
     if (buf->computeChainDataLength() >= zeroCopyWriteChainThreshold_) {
       flags |= folly::WriteFlags::WRITE_MSG_ZEROCOPY;
     } else {