Teach the machine code verifier to use getSubRegisterRegClass().
authorJakob Stoklund Olesen <stoklund@2pi.dk>
Tue, 18 May 2010 17:31:12 +0000 (17:31 +0000)
committerJakob Stoklund Olesen <stoklund@2pi.dk>
Tue, 18 May 2010 17:31:12 +0000 (17:31 +0000)
The old approach was wrong. It had an off-by-one error.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@104034 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/MachineVerifier.cpp

index fdfe2cb30020e84cdc269bb1749faf8dcf538ba6..8baf01c907363a0219ac997d9723addd1d98f762 100644 (file)
@@ -635,11 +635,14 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
         // Virtual register.
         const TargetRegisterClass *RC = MRI->getRegClass(Reg);
         if (SubIdx) {
-          if (RC->subregclasses_begin()+SubIdx >= RC->subregclasses_end()) {
+          const TargetRegisterClass *SRC = RC->getSubRegisterRegClass(SubIdx);
+          if (!SRC) {
             report("Invalid subregister index for virtual register", MO, MONum);
+            *OS << "Register class " << RC->getName()
+                << " does not support subreg index " << SubIdx << "\n";
             return;
           }
-          RC = *(RC->subregclasses_begin()+SubIdx);
+          RC = SRC;
         }
         if (const TargetRegisterClass *DRC = TOI.getRegClass(TRI)) {
           if (RC != DRC && !RC->hasSuperClass(DRC)) {