ARM: pxa: Use setup_timer
authorVaishali Thakkar <vthakkar1994@gmail.com>
Thu, 11 Jun 2015 05:27:35 +0000 (10:57 +0530)
committerRobert Jarzmik <robert.jarzmik@free.fr>
Sat, 18 Jul 2015 10:16:43 +0000 (12:16 +0200)
Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.

A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:

@change@
expression e1, e2, a;
@@

-init_timer(&e1);
+setup_timer(&e1, a, 0UL);
... when != a = e2
-e1.function = a;

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
arch/arm/mach-pxa/sharpsl_pm.c

index 051a6555cbf9ebfae29c4dbe88c3b13c047fbd77..bdc0c41bc4fdca7b0265211743dda4a10b2a649e 100644 (file)
@@ -841,11 +841,9 @@ static int sharpsl_pm_probe(struct platform_device *pdev)
        sharpsl_pm.charge_mode = CHRG_OFF;
        sharpsl_pm.flags = 0;
 
-       init_timer(&sharpsl_pm.ac_timer);
-       sharpsl_pm.ac_timer.function = sharpsl_ac_timer;
+       setup_timer(&sharpsl_pm.ac_timer, sharpsl_ac_timer, 0UL);
 
-       init_timer(&sharpsl_pm.chrg_full_timer);
-       sharpsl_pm.chrg_full_timer.function = sharpsl_chrg_full_timer;
+       setup_timer(&sharpsl_pm.chrg_full_timer, sharpsl_chrg_full_timer, 0UL);
 
        led_trigger_register_simple("sharpsl-charge", &sharpsl_charge_led_trigger);