TTY: Fix error return from tty_ldisc_open()
authorBen Hutchings <ben@decadent.org.uk>
Sat, 11 Dec 2010 05:51:39 +0000 (05:51 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Jan 2011 22:43:01 +0000 (14:43 -0800)
The backported version of "TTY: ldisc, fix open flag handling" in
2.6.32.27 causes tty_ldisc_open() to return 0 on error.  Fix that.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/tty_ldisc.c

index 8b9f1a5c8be87e63ae41794317915d4744eb368a..cf0bfc6b1dbd64753372c3c59bf6b81a4a3a0512 100644 (file)
@@ -451,6 +451,7 @@ static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld)
                ret = ld->ops->open(tty);
                if (ret)
                        clear_bit(TTY_LDISC_OPEN, &tty->flags);
+               return ret;
        }
        return 0;
 }