net/cpsw: optimize the for_each_slave_macro()
authorSebastian Siewior <bigeasy@linutronix.de>
Wed, 24 Apr 2013 08:48:24 +0000 (08:48 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Apr 2013 08:12:29 +0000 (04:12 -0400)
text    data     bss     dec     hex filename
15530      92       4   15626    3d0a cpsw.o.before
15478      92       4   15574    3cd6 cpsw.o.after

52 bytes smaller, 13 for each invocation.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c

index 93a60e238146942a828ca3c0915460e49318331d..1c1e7a82f909f2a6c5e81d498d6bff8e0593bfc5 100644 (file)
@@ -355,12 +355,15 @@ struct cpsw_priv {
 #define napi_to_priv(napi)     container_of(napi, struct cpsw_priv, napi)
 #define for_each_slave(priv, func, arg...)                             \
        do {                                                            \
-               int idx;                                                \
+               struct cpsw_slave *slave;                               \
+               int n;                                                  \
                if (priv->data.dual_emac)                               \
                        (func)((priv)->slaves + priv->emac_port, ##arg);\
                else                                                    \
-                       for (idx = 0; idx < (priv)->data.slaves; idx++) \
-                               (func)((priv)->slaves + idx, ##arg);    \
+                       for (n = (priv)->data.slaves,                   \
+                                       slave = (priv)->slaves;         \
+                                       n; n--)                         \
+                               (func)(slave++, ##arg);                 \
        } while (0)
 #define cpsw_get_slave_ndev(priv, __slave_no__)                                \
        (priv->slaves[__slave_no__].ndev)