regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
authorRoel Kluin <roel.kluin@gmail.com>
Tue, 15 Dec 2009 19:07:31 +0000 (20:07 +0100)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Thu, 17 Dec 2009 10:27:30 +0000 (10:27 +0000)
ret should be signed to notice a failure in wm831x_reg_read().

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/wm831x-ldo.c

index 902db56ce099676f6a2a3f2483dd0d7b3c75811f..61e02ac2fda334f9e17dd145cf65d938f816548e 100644 (file)
@@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)
        struct wm831x_ldo *ldo = rdev_get_drvdata(rdev);
        struct wm831x *wm831x = ldo->wm831x;
        int on_reg = ldo->base + WM831X_LDO_ON_CONTROL;
-       unsigned int ret;
+       int ret;
 
        ret = wm831x_reg_read(wm831x, on_reg);
        if (ret < 0)