Staging: mt29f_spinand: Prefer using the BIT macro
authorEva Rachel Retuya <eraretuya@gmail.com>
Sat, 24 Oct 2015 14:35:47 +0000 (22:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Oct 2015 19:09:16 +0000 (04:09 +0900)
Replace all instances of bit shifting on 1 with the BIT(x) macro. In
addition, convert other non-1 shift operations with the equivalent
BIT(x) macro for uniformity. Issue pointed out by checkpatch.

CHECK: Prefer using the BIT macro

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt29f_spinand/mt29f_spinand.h

index fe6c15a50c35136944e2bc6d679a98c5d0067443..ae62975cf44a7bb4fa37ba008191c6e6968666b2 100644 (file)
 
 /* status */
 #define STATUS_OIP_MASK                        0x01
-#define STATUS_READY                   (0 << 0)
-#define STATUS_BUSY                    (1 << 0)
+#define STATUS_READY                   0
+#define STATUS_BUSY                    BIT(0)
 
 #define STATUS_E_FAIL_MASK             0x04
-#define STATUS_E_FAIL                  (1 << 2)
+#define STATUS_E_FAIL                  BIT(2)
 
 #define STATUS_P_FAIL_MASK             0x08
-#define STATUS_P_FAIL                  (1 << 3)
+#define STATUS_P_FAIL                  BIT(3)
 
 #define STATUS_ECC_MASK                        0x30
-#define STATUS_ECC_1BIT_CORRECTED      (1 << 4)
-#define STATUS_ECC_ERROR               (2 << 4)
-#define STATUS_ECC_RESERVED            (3 << 4)
+#define STATUS_ECC_1BIT_CORRECTED      BIT(4)
+#define STATUS_ECC_ERROR               BIT(5)
+#define STATUS_ECC_RESERVED            (BIT(5) | BIT(4))
 
 /*ECC enable defines*/
 #define OTP_ECC_MASK                   0x10