V4L/DVB (13292): tvp514x: recognize the error case in tvp514x_read_reg()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 4 Nov 2009 18:35:09 +0000 (15:35 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 5 Dec 2009 20:41:13 +0000 (18:41 -0200)
i2c_smbus_read_byte_data() returns a negative value on error. It is very
likely to be != -1 (-EPERM).

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/tvp514x.c

index 244372627df2993ffcfa144854e3893a778357f2..26b4e718cd6d74226cd0320c1a633cedae16041c 100644 (file)
@@ -272,7 +272,7 @@ static int tvp514x_read_reg(struct v4l2_subdev *sd, u8 reg)
 read_again:
 
        err = i2c_smbus_read_byte_data(client, reg);
-       if (err == -1) {
+       if (err < 0) {
                if (retry <= I2C_RETRY_COUNT) {
                        v4l2_warn(sd, "Read: retry ... %d\n", retry);
                        retry++;